feat(nimbus): Add basic feature tracking table to feature health page. #13749
+122
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is blocked on #13742 |
b4handjr
force-pushed
the
fix-13715
branch
6 times, most recently
from
f22a86a to
718c788
Compare
b4handjr
requested review from
freshstrangemusic,
jaredlockhart and
yashikakhurana
as code owners
|
yashikakhurana
requested changes
Oct 24, 2025
There was a problem hiding this comment.
Thanks @b4handjr, good approach on splitting this up, just one minor suggestion otherwise looks good
experimenter/experimenter/nimbus_ui/templates/nimbus_experiments/features.html
Outdated
Show resolved
Hide resolved
yashikakhurana
requested changes
Oct 27, 2025
Comment on lines
336
to
337
| <img src="{% static 'assets/qa-runs.svg' %}" | ||
| <img src="{% static 'assets/feature-changes.svg' %}" |
There was a problem hiding this comment.
I think its by mistake, you are using both qa-run and feature change svg?
There was a problem hiding this comment.
Ah wow, that merge went bad.
yashikakhurana
added
preview
yashikakhurana
requested changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This commit
Fixes #13715